Check that --ip-range is a CIDR address#5483
Merged
thaJeztah merged 1 commit intodocker:masterfrom Sep 26, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5483 +/- ##
===========================================
+ Coverage 43.17% 60.03% +16.86%
===========================================
Files 6 345 +339
Lines 227 23434 +23207
===========================================
+ Hits 98 14068 +13970
- Misses 123 8391 +8268
- Partials 6 975 +969 |
Signed-off-by: Rob Murray <rob.murray@docker.com>
e71bb6d to
8fca0a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Avoid this sort of confusion (from the community Slack) ...
- How I did it
Check that
--ip-rangeis a CIDR address, to produce a better error message.The original error message was from the CLI, but it used
subnetMatches(s,r)to check that the range was ok - that function tries to deal withrbeing a single address as well as a subnet, so it missed the problem. (Validation at the daemon end of the API is already ok.)- How to verify it
Updated test, and ...
- Description for the changelog